Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[glsl-in]: Document some fields of naga::front::glsl::context::Context. #2244

Merged
merged 2 commits into from
Feb 16, 2023

Conversation

jimblandy
Copy link
Member

No description provided.

@jimblandy jimblandy added area: front-end Input formats for conversion lang: GLSL OpenGL Shading Language area: doc Documentation for crate items, public or private labels Feb 6, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2023

Codecov Report

Merging #2244 (e8a611a) into master (2d0aab8) will increase coverage by 13.16%.
The diff coverage is 91.22%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           master    #2244       +/-   ##
===========================================
+ Coverage   69.09%   82.26%   +13.16%     
===========================================
  Files          77       80        +3     
  Lines       28319    42839    +14520     
===========================================
+ Hits        19567    35240    +15673     
+ Misses       8752     7599     -1153     
Impacted Files Coverage Δ
src/front/glsl/builtins.rs 82.72% <ø> (+1.50%) ⬆️
src/front/glsl/mod.rs 96.61% <ø> (-3.39%) ⬇️
src/front/glsl/parser/declarations.rs 74.57% <ø> (+13.15%) ⬆️
src/front/glsl/parser/functions.rs 85.95% <ø> (+20.98%) ⬆️
src/front/glsl/functions.rs 89.29% <91.17%> (+1.08%) ⬆️
src/front/glsl/context.rs 92.00% <100.00%> (+1.29%) ⬆️
src/front/wgsl/parse/ast.rs 22.85% <0.00%> (-77.15%) ⬇️
src/front/glsl/token.rs 70.00% <0.00%> (-30.00%) ⬇️
src/back/hlsl/mod.rs 78.33% <0.00%> (-12.30%) ⬇️
src/proc/layouter.rs 87.70% <0.00%> (-7.04%) ⬇️
... and 76 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@JCapucho
Copy link
Collaborator

JCapucho commented Feb 8, 2023

@jimblandy needs a rebase (I tried to do it but don't have permissions)

@jimblandy jimblandy enabled auto-merge (squash) February 16, 2023 23:15
@jimblandy jimblandy merged commit dce689c into gfx-rs:master Feb 16, 2023
@jimblandy jimblandy deleted the glsl-in-docs branch September 20, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: doc Documentation for crate items, public or private area: front-end Input formats for conversion lang: GLSL OpenGL Shading Language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants