valid: Improve forward declaration validation #2232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The handle dependency validation code was using the handle's index directly while trying to erase the handle type. This would cause the validator to crash while processing the first handle of the arena since it would be trying to construct a `NonZeroU32` with a zero. This commit fixes the issue by adding 1 to the index which not only fixes this panic but also makes so that the created Handle is equal to the passed handle (minus the type that was erased) It also fixes the error message not including the subject's kind
This commit enforces the forward dependency rules on the IR across functions and their calls, this fixes a crash in a later stage of the validator.
JCapucho
force-pushed
the
validate-forward-handle
branch
from
090411b
to
fd63680
Compare
jimblandy
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with the dependency code and adds dependency validation to function calls.
The handle validator had an issue that caused it to try to build a handle with a zero based index while type erasing handles, this would crash because the index must be a
NonZeroU32and it would also not be correct since the handle would be off by one from the original handle.It also fixes the error message for the forward dependency not containing the subject's kind.
Lastly it adds a dependency check for function calls, to prevent forward declarations to pass to further stages and cause crashes (mitigates gfx-rs/wgpu#4477)