Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glsl-in: Migrate to SymbolTable #2044

Merged
merged 2 commits into from
Sep 5, 2022
Merged

Conversation

JCapucho
Copy link
Collaborator

@JCapucho JCapucho commented Sep 3, 2022

Moves the glsl frontend from it's custom solution for lexical scopes to the new SymbolTable.

Adds an add_root method to SymbolTable that's needed for glsl builtins and implement Debug.

Copy link
Member

@jimblandy jimblandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

src/front/mod.rs Show resolved Hide resolved
Copy link
Member

@jimblandy jimblandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@JCapucho JCapucho merged commit d9c9fe6 into gfx-rs:master Sep 5, 2022
@JCapucho JCapucho deleted the glsl-symbol-table branch September 5, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants