Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wgsl-in: Rename Scope to Rule, since we now have lexical scope. #2042

Merged
merged 1 commit into from
Sep 3, 2022

Conversation

jimblandy
Copy link
Member

Rename related functions and variables appropriately.

Also, make Rule private to the WGSL front end, and remove the unused ImportDecl variant.

Rename related functions and variables appropriately.

Also, make `Rule` private to the WGSL front end, and remove the unused
`ImportDecl` variant.
Copy link
Collaborator

@JCapucho JCapucho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rule doesn't sound right to me, but it makes sense when considered as grammar rule and I don't have any better suggestions, so fine by me.

@jimblandy jimblandy merged commit 13a0d28 into gfx-rs:master Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants