Saturate #2025
Merged
Saturate #2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JCapucho
requested changes
Aug 11, 2022
There was a problem hiding this comment.
Thanks for your contribution, there are some problems with some parts of it and some code could be improved but overall it's on the right track.
You should add a test (math-functions.wgsl seems like a good place).
Also the spec you point to is outdated, the newer version is at https://gpuweb.github.io/gpuweb/wgsl/#saturate-float-builtin
JCapucho
approved these changes
Aug 12, 2022
Cool, I’ll be on the lookout 👀 |
Co-authored-by: João Capucho <jcapucho7@gmail.com>
|
Thanks for you work, I've gone ahead and rebased it so now it's ready to be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds saturate and converts it to
clamp(e, 0.0, 1.0)where necessary.