Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add emit_to_{stderr,string} helpers to validation error #2012

Merged
merged 4 commits into from
Aug 6, 2022

Conversation

nolanderc
Copy link
Contributor

Mirrors those already found for parse errors. Also took the time to remove the StringErrorBuffer writer in favor of the existing NoColor writer and added the emit_to_string_with_path method to complete the set.

Copy link
Collaborator

@JCapucho JCapucho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JCapucho JCapucho merged commit cfbc91d into gfx-rs:master Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants