Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[msl-out] Insert padding initialization for global constants #1988

Merged
merged 1 commit into from
Jun 17, 2022
Merged

[msl-out] Insert padding initialization for global constants #1988

merged 1 commit into from
Jun 17, 2022

Conversation

teoxoy
Copy link
Member

@teoxoy teoxoy commented Jun 16, 2022

fixes #1974

jimblandy
jimblandy approved these changes Jun 16, 2022
View reviewed changes
Copy link
Member

@jimblandy jimblandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's also add a comment on Writer::struct_member_pads explaining what it means.

@teoxoy teoxoy enabled auto-merge (rebase) June 17, 2022 08:51
@teoxoy teoxoy merged commit 89f24b6 into gfx-rs:master Jun 17, 2022
@teoxoy teoxoy deleted the msl-padding branch June 17, 2022 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimblandy jimblandy jimblandy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[msl-out] Handle struct padding in global variable initialiser
2 participants
@teoxoy @jimblandy