Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glsl-in: Stop emitter in conditional #1952

Merged
merged 1 commit into from
May 30, 2022

Conversation

JCapucho
Copy link
Collaborator

This wasn't being done when there were no implicit conversions, causing
the emitter to panic.

closes #1942

This wasn't being done when there were no implicit conversions, causing
the emitter to panic.
Copy link
Member

@jimblandy jimblandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry I didn't catch this in the first review. Thanks for the fix.

@jimblandy jimblandy merged commit 9e75332 into gfx-rs:master May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[glsl] Unreachable code error causing main thread crash during GLSL validation
2 participants