Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glsl-out: Bake Constant expressions #1950

Closed
wants to merge 1 commit into from
Closed

glsl-out: Bake Constant expressions #1950

wants to merge 1 commit into from

Conversation

JCapucho
Copy link
Collaborator

These expressions don't appear in Emit statements so they need to be
baked manually.

closes #1944

@JCapucho JCapucho changed the title glsl-out: Bake pre emit expressions glsl-out: Bake Constant expressions May 27, 2022
@JCapucho
glsl-out: Bake Constant expressions
174750a 
These expressions don't appear in Emit statements so they need to be
baked manually.
jimblandy
jimblandy requested changes May 30, 2022
View reviewed changes
Copy link
Member

@jimblandy jimblandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes the output harder to follow, for no good reason. Wouldn't it be better to just never put Constant expressions in Writer::need_bake_expressions in the first place?

@JCapucho
Copy link
Collaborator Author

This makes the output harder to follow, for no good reason. Wouldn't it be better to just never put Constant expressions in Writer::need_bake_expressions in the first place?

Definitely feasible, we could just use write_expr in the write_dot_product function and let the backend cache as it sees fit

@JCapucho
Copy link
Collaborator Author

JCapucho commented Jun 7, 2022

@jimblandy I've opened #1975 to replace this PR, can you take a look?

@JCapucho JCapucho closed this Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimblandy jimblandy jimblandy requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[glsl-out] Thread panic when generating GLSL of dot function with zero-valued vector(s)
2 participants
@JCapucho @jimblandy