Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error for matrices without f32 scalar type #1917

Merged
merged 1 commit into from
May 14, 2022

Conversation

grovesNL
Copy link
Collaborator

Fixes #1896

@grovesNL grovesNL force-pushed the non-floating-matrix branch 2 times, most recently from 5e45fbe to 3fe9697 Compare May 14, 2022 02:49
Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, left a few comments.

src/front/wgsl/mod.rs Outdated Show resolved Hide resolved
src/front/wgsl/construction.rs Outdated Show resolved Hide resolved
src/front/wgsl/mod.rs Outdated Show resolved Hide resolved
@grovesNL
Copy link
Collaborator Author

Thank you! Updated the PR

Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@teoxoy teoxoy merged commit 60ae549 into gfx-rs:master May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[wgsl-in] Error on matrices with non float scalar kinds
2 participants