Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modulo improvements #1867

Merged
merged 6 commits into from
May 10, 2022
Merged

Modulo improvements #1867

merged 6 commits into from
May 10, 2022

Conversation

teoxoy
Copy link
Member

@teoxoy teoxoy commented Apr 27, 2022

With these changes we should be on par with the WGSL spec (not including handling undefined behavior in the back-ends; added TODOs for those).

fixes #802

Commits are self contained - no need to squash.

@teoxoy teoxoy marked this pull request as ready for review April 28, 2022 18:01
Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

top work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle differences between the glsl mod function and the metal::fmod function.
2 participants