Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify accepted types for Expression::AccessIndex #1862

Merged
merged 2 commits into from
Apr 26, 2022
Merged

Clarify accepted types for Expression::AccessIndex #1862

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5ba5e6
Clarify accepted types for `AccessIndex` and remove `Constant` fragment
NoelTautges Apr 25, 2022
3e265b9
Remove spaces
NoelTautges Apr 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1108,14 +1108,15 @@ pub enum Expression {
base: Handle<Expression>,
index: Handle<Expression>,
},
/// Array access with a known index.
/// Access the same types as [`Access`], plus [`Struct`] with a known index.
///
/// [`Access`]: Expression::Access
/// [`Struct`]: TypeInner::Struct
AccessIndex {
base: Handle<Expression>,
index: u32,
},
/// Constant value.
///
/// Every `Constant` expression
NoelTautges marked this conversation as resolved.
Show resolved Hide resolved
Constant(Handle<Constant>),
/// Splat scalar into a vector.
Splat {
Expand Down