Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hlsl-out] Flesh out matrix handling documentation. #1850

Merged
merged 1 commit into from
Apr 18, 2022
Merged

[hlsl-out] Flesh out matrix handling documentation. #1850

merged 1 commit into from
Apr 18, 2022

Conversation

jimblandy
Copy link
Member

No description provided.

teoxoy
teoxoy approved these changes Apr 17, 2022
View reviewed changes
Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the 2 comments, this is really well written!

src/back/hlsl/mod.rs Outdated Show resolved Hide resolved
src/back/hlsl/mod.rs Outdated Show resolved Hide resolved
@jimblandy jimblandy requested a review from teoxoy April 18, 2022 03:20
@jimblandy jimblandy merged commit 0aa6b69 into gfx-rs:master Apr 18, 2022
@jimblandy jimblandy deleted the hlsl-document-matrix-hacks branch April 18, 2022 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoxoy teoxoy Awaiting requested review from teoxoy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimblandy @teoxoy