-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
glsl-in: support for storage image types #1723
Conversation
6e9829a
to
0a93793
Compare
let's support it in the IR, but have a capability in the validator to check for it. Relevant SPIR-V capability - https://www.khronos.org/registry/vulkan/specs/1.2/html/chap31.html#features-shaderStorageImageMultisample
Not sure what to do with it. I suggest just not supporting this in Naga, at least for now.
We'll probably just need to add them.
This doesn't appear useful in modern APIs, since one would just create a 2D view instead. It looks like a GLSL artifact, so we shouldn't try supporting it. |
Suggestions are optional, please land when you feel ready. |
0a93793
to
690ad19
Compare
I've applied your suggestions, I'll merge this as an initial implementation and work on the missing bits that require some IR changes later when I have more time. |
690ad19
to
0f0c259
Compare
Adds support for the
gimageDim
family of types and theimageSize
,imageLoad
andimageStore
functions.Missing
support for image types as function arguments(impossible see Format layout qualifiers on image function parameters? KhronosGroup/GLSL#57,writeonly
images should work but see the following points)Unresolved
writeonly
storage images to not have their format specified, naga doesn't like it, once again how do we handle it?imageLoad/Store
, how do we handle it?Closes #1456