Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wgsl: declare attribtues with @ #1676

Merged
merged 1 commit into from
Jan 21, 2022
Merged

wgsl: declare attribtues with @ #1676

merged 1 commit into from
Jan 21, 2022

Conversation

kvark
Copy link
Member

@kvark kvark commented Jan 19, 2022

BREAKS EVERY PROGRAM
Matches gpuweb/gpuweb#2517

@kvark kvark requested a review from jimblandy January 19, 2022 15:35
Copy link
Contributor

@mehmetoguzderin mehmetoguzderin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(approving to remove my change request)

src/back/wgsl/writer.rs Show resolved Hide resolved
src/front/wgsl/mod.rs Show resolved Hide resolved
src/front/wgsl/mod.rs Outdated Show resolved Hide resolved
@jimblandy
Copy link
Member

Approved, but do note the one error message that needs a tweak

@kvark kvark enabled auto-merge (rebase) January 21, 2022 00:41
@kvark kvark merged commit 4bd1efc into gfx-rs:master Jan 21, 2022
@kvark kvark deleted the attribute branch January 21, 2022 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants