New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glsl-out: fix emission of location/binding attributes #1100

Merged

kvark merged 1 commit into gfx-rs:master from kvark:glsl-location

Jul 17, 2021

Member

kvark commented Jul 17, 2021

Should help gfx-rs/wgpu#1617
Here is the breakdown:

"location" is supported unconditionally for VS inputs and FS outputs
"location" requires GLSL ES 310 for varyings (VS outputs and FS inputs)
"binding" requires GLSL ES 310


          glsl-out: fix emission of location/binding attributes

b29f56e

Member Author

kvark commented Jul 17, 2021

Reviewed by @magcius

kvark merged commit e76824a into gfx-rs:master

kvark deleted the glsl-location branch

July 17, 2021 03:04

zicklag mentioned this pull request

WebGL2 backend gfx-rs/wgpu#1617

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet