-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate with snapshot testing #41
Comments
This should close gfx-rs#41
I just pushed a branch with a prototype of this implementation, but maybe it doesn't make sense to open a PR until #48 is merged. |
Ah I see. Yes, let's merge serialization first, then make it nice (the |
This should close gfx-rs#41
One issue: having the handle ids in the snapshots will fail the cases where ordering changes, but module is still semantically identical. Think e.g. a different glsl parser that orders expressions slightly different. I'm not sure general snapshot testing can handle this. I've previously worked on some similar testing for a glTF exporter, where we ended up de-referencing indexed data before doing comparison between actual and expected results. In this way you 'abstract away' the specific ordering and index values, where they don't have any semantic difference. |
https://github.com/mitsuhiko/insta
Depends on #32
The text was updated successfully, but these errors were encountered: