-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic debug markers API #3169
Basic debug markers API #3169
Conversation
Question to @msiglreith and @grovesNL : should we work with |
Having a |
@msiglreith you are saying - have both |
@kvark one function ( |
@msiglreith so for Metal accessed from Rust code, it would mean 2 conversions:
|
bors try |
tryTimed out |
Let's keep thinking about this. There doesn't appear to be an optimal solution yet. |
3169: Basic debug markers API r=kvark a=kvark Addresses the "Section/call marking" API portion of #1508 (only Vulkan implementation so far) PR checklist: - [ ] `make` succeeds (on *nix) - [ ] `make reftests` succeeds - [ ] tested examples with the following backends: - [ ] `rustfmt` run on changed code Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
what's going on with CI? both Travis and bors appear to go crazy, even though it's weekend time. |
3169: Basic debug markers API r=kvark a=kvark Addresses the "Section/call marking" API portion of #1508 (only Vulkan implementation so far) PR checklist: - [ ] `make` succeeds (on *nix) - [ ] `make reftests` succeeds - [ ] tested examples with the following backends: - [ ] `rustfmt` run on changed code Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
Build failed |
bors r+ |
3169: Basic debug markers API r=kvark a=kvark Addresses the "Section/call marking" API portion of #1508 (only Vulkan implementation so far) PR checklist: - [ ] `make` succeeds (on *nix) - [ ] `make reftests` succeeds - [ ] tested examples with the following backends: - [ ] `rustfmt` run on changed code Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
Build failed |
All the builds have passed.. just not on a single run. It's always one of the mac builds that times out. |
bors retry |
3169: Basic debug markers API r=kvark a=kvark Addresses the "Section/call marking" API portion of #1508 (only Vulkan implementation so far) PR checklist: - [ ] `make` succeeds (on *nix) - [ ] `make reftests` succeeds - [ ] tested examples with the following backends: - [ ] `rustfmt` run on changed code Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
Build failed |
bors r+ |
3169: Basic debug markers API r=kvark a=kvark Addresses the "Section/call marking" API portion of #1508 (only Vulkan implementation so far) PR checklist: - [ ] `make` succeeds (on *nix) - [ ] `make reftests` succeeds - [ ] tested examples with the following backends: - [ ] `rustfmt` run on changed code Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
Build failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors r+
3169: Basic debug markers API r=grovesNL a=kvark Addresses the "Section/call marking" API portion of #1508 (only Vulkan implementation so far) PR checklist: - [ ] `make` succeeds (on *nix) - [ ] `make reftests` succeeds - [ ] tested examples with the following backends: - [ ] `rustfmt` run on changed code Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
Build failed |
Other users have the same issue in https://travis-ci.community/t/macos-build-an-error-occurred-while-generating-the-build-script/7684 |
bors retry |
3169: Basic debug markers API r=grovesNL a=kvark Addresses the "Section/call marking" API portion of #1508 (only Vulkan implementation so far) PR checklist: - [ ] `make` succeeds (on *nix) - [ ] `make reftests` succeeds - [ ] tested examples with the following backends: - [ ] `rustfmt` run on changed code Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
Timed out |
Bors retry
… On Mar 22, 2020, at 14:29, bors[bot] ***@***.***> wrote:
Timed out
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Build succeeded |
Addresses the "Section/call marking" API portion of #1508 (only Vulkan implementation so far)
PR checklist:
make
succeeds (on *nix)make reftests
succeedsrustfmt
run on changed code