Basic debug markers API #3169
Merged
Basic debug markers API #3169
+110
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Question to @msiglreith and @grovesNL : should we work with |
|
Having a |
|
@msiglreith you are saying - have both |
|
@kvark one function ( |
|
@msiglreith so for Metal accessed from Rust code, it would mean 2 conversions:
|
|
bors try |
tryTimed out |
|
Let's keep thinking about this. There doesn't appear to be an optimal solution yet. |
bors bot
added a commit
that referenced
this pull request
Mar 22, 2020
3169: Basic debug markers API r=kvark a=kvark Addresses the "Section/call marking" API portion of #1508 (only Vulkan implementation so far) PR checklist: - [ ] `make` succeeds (on *nix) - [ ] `make reftests` succeeds - [ ] tested examples with the following backends: - [ ] `rustfmt` run on changed code Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
|
what's going on with CI? both Travis and bors appear to go crazy, even though it's weekend time. |
bors bot
added a commit
that referenced
this pull request
Mar 22, 2020
3169: Basic debug markers API r=kvark a=kvark Addresses the "Section/call marking" API portion of #1508 (only Vulkan implementation so far) PR checklist: - [ ] `make` succeeds (on *nix) - [ ] `make reftests` succeeds - [ ] tested examples with the following backends: - [ ] `rustfmt` run on changed code Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
Build failed |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Mar 22, 2020
3169: Basic debug markers API r=kvark a=kvark Addresses the "Section/call marking" API portion of #1508 (only Vulkan implementation so far) PR checklist: - [ ] `make` succeeds (on *nix) - [ ] `make reftests` succeeds - [ ] tested examples with the following backends: - [ ] `rustfmt` run on changed code Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
Build failed |
|
All the builds have passed.. just not on a single run. It's always one of the mac builds that times out. |
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Mar 22, 2020
3169: Basic debug markers API r=kvark a=kvark Addresses the "Section/call marking" API portion of #1508 (only Vulkan implementation so far) PR checklist: - [ ] `make` succeeds (on *nix) - [ ] `make reftests` succeeds - [ ] tested examples with the following backends: - [ ] `rustfmt` run on changed code Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
Build failed |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Mar 22, 2020
3169: Basic debug markers API r=kvark a=kvark Addresses the "Section/call marking" API portion of #1508 (only Vulkan implementation so far) PR checklist: - [ ] `make` succeeds (on *nix) - [ ] `make reftests` succeeds - [ ] tested examples with the following backends: - [ ] `rustfmt` run on changed code Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
Build failed |
bors bot
added a commit
that referenced
this pull request
Mar 22, 2020
3169: Basic debug markers API r=grovesNL a=kvark Addresses the "Section/call marking" API portion of #1508 (only Vulkan implementation so far) PR checklist: - [ ] `make` succeeds (on *nix) - [ ] `make reftests` succeeds - [ ] tested examples with the following backends: - [ ] `rustfmt` run on changed code Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
Build failed |
|
Other users have the same issue in https://travis-ci.community/t/macos-build-an-error-occurred-while-generating-the-build-script/7684 |
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Mar 22, 2020
3169: Basic debug markers API r=grovesNL a=kvark Addresses the "Section/call marking" API portion of #1508 (only Vulkan implementation so far) PR checklist: - [ ] `make` succeeds (on *nix) - [ ] `make reftests` succeeds - [ ] tested examples with the following backends: - [ ] `rustfmt` run on changed code Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
Timed out |
|
Bors retry
… On Mar 22, 2020, at 14:29, bors[bot] ***@***.***> wrote:
Timed out
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Build succeeded |
This was referenced Mar 22, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the "Section/call marking" API portion of #1508 (only Vulkan implementation so far)
PR checklist:
makesucceeds (on *nix)make reftestssucceedsrustfmtrun on changed code