Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic debug markers API #3169

Merged
merged 1 commit into from
Mar 22, 2020
Merged

Basic debug markers API #3169

merged 1 commit into from
Mar 22, 2020

Conversation

kvark
Copy link
Member

@kvark kvark commented Mar 21, 2020

Addresses the "Section/call marking" API portion of #1508 (only Vulkan implementation so far)
PR checklist:

  • make succeeds (on *nix)
  • make reftests succeeds
  • tested examples with the following backends:
  • rustfmt run on changed code

@kvark
Copy link
Member Author

kvark commented Mar 21, 2020

Question to @msiglreith and @grovesNL : should we work with &CStr for all the labels and markers? This was suggested by @aloucks in gfx-rs/wgpu#528 (comment)

@msiglreith
Copy link
Contributor

Having a CStr variant as well sounds fine to me - wgpu can use CStr and others might want to go with &str

@kvark
Copy link
Member Author

kvark commented Mar 21, 2020

@msiglreith you are saying - have both CStr and str? Or something like gfx-rs/wgpu#528 (comment) ?

@msiglreith
Copy link
Contributor

@kvark one function (CStr) for the backends to implement and an additional which takes a &str and forwards it to the first function

@kvark
Copy link
Member Author

kvark commented Mar 21, 2020

@msiglreith so for Metal accessed from Rust code, it would mean 2 conversions:

  1. from str to CStr
  2. from CStr to NSString

@kvark
Copy link
Member Author

kvark commented Mar 21, 2020

bors try

bors bot added a commit that referenced this pull request Mar 21, 2020
@bors
Copy link
Contributor

bors bot commented Mar 21, 2020

try

Timed out

@kvark
Copy link
Member Author

kvark commented Mar 22, 2020

Let's keep thinking about this. There doesn't appear to be an optimal solution yet.
bors r+

bors bot added a commit that referenced this pull request Mar 22, 2020
3169: Basic debug markers API r=kvark a=kvark

Addresses the "Section/call marking" API portion of #1508 (only Vulkan implementation so far)
PR checklist:
- [ ] `make` succeeds (on *nix)
- [ ] `make reftests` succeeds
- [ ] tested examples with the following backends:
- [ ] `rustfmt` run on changed code


Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
@kvark
Copy link
Member Author

kvark commented Mar 22, 2020

what's going on with CI? both Travis and bors appear to go crazy, even though it's weekend time.
bors retry

bors bot added a commit that referenced this pull request Mar 22, 2020
3169: Basic debug markers API r=kvark a=kvark

Addresses the "Section/call marking" API portion of #1508 (only Vulkan implementation so far)
PR checklist:
- [ ] `make` succeeds (on *nix)
- [ ] `make reftests` succeeds
- [ ] tested examples with the following backends:
- [ ] `rustfmt` run on changed code


Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
@bors
Copy link
Contributor

bors bot commented Mar 22, 2020

Build failed

@kvark
Copy link
Member Author

kvark commented Mar 22, 2020

bors r+

bors bot added a commit that referenced this pull request Mar 22, 2020
3169: Basic debug markers API r=kvark a=kvark

Addresses the "Section/call marking" API portion of #1508 (only Vulkan implementation so far)
PR checklist:
- [ ] `make` succeeds (on *nix)
- [ ] `make reftests` succeeds
- [ ] tested examples with the following backends:
- [ ] `rustfmt` run on changed code


Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
@bors
Copy link
Contributor

bors bot commented Mar 22, 2020

Build failed

@aloucks
Copy link
Contributor

aloucks commented Mar 22, 2020

All the builds have passed.. just not on a single run. It's always one of the mac builds that times out.

@kvark
Copy link
Member Author

kvark commented Mar 22, 2020

bors retry

bors bot added a commit that referenced this pull request Mar 22, 2020
3169: Basic debug markers API r=kvark a=kvark

Addresses the "Section/call marking" API portion of #1508 (only Vulkan implementation so far)
PR checklist:
- [ ] `make` succeeds (on *nix)
- [ ] `make reftests` succeeds
- [ ] tested examples with the following backends:
- [ ] `rustfmt` run on changed code


Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
@bors
Copy link
Contributor

bors bot commented Mar 22, 2020

Build failed

@kvark
Copy link
Member Author

kvark commented Mar 22, 2020

bors r+

bors bot added a commit that referenced this pull request Mar 22, 2020
3169: Basic debug markers API r=kvark a=kvark

Addresses the "Section/call marking" API portion of #1508 (only Vulkan implementation so far)
PR checklist:
- [ ] `make` succeeds (on *nix)
- [ ] `make reftests` succeeds
- [ ] tested examples with the following backends:
- [ ] `rustfmt` run on changed code


Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
@bors
Copy link
Contributor

bors bot commented Mar 22, 2020

Build failed

Copy link
Contributor

@grovesNL grovesNL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Mar 22, 2020
3169: Basic debug markers API r=grovesNL a=kvark

Addresses the "Section/call marking" API portion of #1508 (only Vulkan implementation so far)
PR checklist:
- [ ] `make` succeeds (on *nix)
- [ ] `make reftests` succeeds
- [ ] tested examples with the following backends:
- [ ] `rustfmt` run on changed code


Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
@bors
Copy link
Contributor

bors bot commented Mar 22, 2020

Build failed

@grovesNL
Copy link
Contributor

Other users have the same issue in https://travis-ci.community/t/macos-build-an-error-occurred-while-generating-the-build-script/7684

@kvark
Copy link
Member Author

kvark commented Mar 22, 2020

bors retry

bors bot added a commit that referenced this pull request Mar 22, 2020
3169: Basic debug markers API r=grovesNL a=kvark

Addresses the "Section/call marking" API portion of #1508 (only Vulkan implementation so far)
PR checklist:
- [ ] `make` succeeds (on *nix)
- [ ] `make reftests` succeeds
- [ ] tested examples with the following backends:
- [ ] `rustfmt` run on changed code


Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
@bors
Copy link
Contributor

bors bot commented Mar 22, 2020

Timed out

@kvark
Copy link
Member Author

kvark commented Mar 22, 2020 via email

@bors
Copy link
Contributor

bors bot commented Mar 22, 2020

Build succeeded

@bors bors bot merged commit bf1c536 into gfx-rs:master Mar 22, 2020
@kvark kvark deleted the debug-markers branch March 22, 2020 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants