Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rule for import shadowing #111

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

felixvd
Copy link
Contributor

@felixvd felixvd commented Sep 28, 2023

Closes #110

Adds a separate rule for import statements.

Turns out that import statements were already checked, just not comprehensively. This should do it.

@felixvd felixvd force-pushed the add-import-shadowing branch from 0878350 to 04d2f7c Compare September 28, 2023 07:13
@felixvd felixvd force-pushed the add-import-shadowing branch from 04d2f7c to dfbdca6 Compare September 28, 2023 07:20
@felixvd
Copy link
Contributor Author

felixvd commented Oct 3, 2023

Friendly ping @gforcada

@gforcada
Copy link
Owner

gforcada commented Nov 1, 2023

😱 sorry, I totally missed this PR! 🤦🏾

It looks great, actually I was fixing/improving the structure of the project, so, while I can't do it right now as my kids woke up, I will leave the tab open and try to do it within today/next few days! 🤞🏾

Thanks again for the contribution and sorry, again, for missing it 😖

@gforcada gforcada merged commit d9246da into gforcada:master Nov 1, 2023
@gforcada
Copy link
Owner

gforcada commented Nov 1, 2023

@felixvd thanks for the PR!! all looked great, it's already merged and I'm about to make a release 🎉

@gforcada
Copy link
Owner

gforcada commented Nov 1, 2023

Release is out flake8-builtins==2.2.0a0

I created an alpha, just to have a double check before a final release, as I changed a few things (switch to pyproject.toml for example) and I'm not comfortable of doing a final release with it right away 😅

Please give it a try and let me know if it works for you with your new improvements 👍🏾

@felixvd felixvd deleted the add-import-shadowing branch November 1, 2023 23:29
@felixvd
Copy link
Contributor Author

felixvd commented Nov 1, 2023

Thank you very much and no worries @gforcada . Appreciate your effort maintaining this!

edit: Works like a charm. Thanks!

@lazydroid
Copy link

@felixvd congrats!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn when shadowing built-ins via from X import Y
3 participants