pywsgi treats invalid HTTP method as a format string

[sgrimm]

• gevent version: 20.9.0
• Python version: cPython 3.8.5
• Operating System: BalenaOS (Debian Linux 10.4 Linux 5.4.58 aarch64)

Description:

A client sent an HTTPS request to a WSGIServer that didn't have SSL enabled. The server was unable to cleanly log the usual error message about an invalid HTTP method because the HTTPS data happened to include a percent sign.

Traceback (most recent call last):
  File "/usr/local/lib/python3.8/site-packages/gevent/pywsgi.py", line 666, in handle_one_request
    if not self.read_request(self.requestline):
  File "/usr/local/lib/python3.8/site-packages/gevent/pywsgi.py", line 523, in read_request
    raise _InvalidClientRequest('Invalid http version: %r' % (raw_requestline,))
gevent.pywsgi._InvalidClientRequest: Invalid http version: '\x16\x03\x01\x02\x00\x01\x00\x01ü\x03\x03Î2\x11"\x18³\x1cðb\x06%]\\Á_ãçÎl½\x7fä³\x9a\x9d\x93k«o{&\xad aÏ\x06KhÛ\x80ÕÐTu¹0ÿ\n'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.8/site-packages/gevent/pywsgi.py", line 569, in log_error
    message = msg % args
TypeError: not enough arguments for format string

What I've run:

Assuming there's a non-HTTPS WSGIServer running on port 5000, the extra exception is easy to reproduce:

echo '%' | nc localhost 5000

[jamadden]

Thanks for the report.