SDK-1133: Retrieve the same attribute with different constraints

[emmas-yoti]

Add get_all_attributes_by_name(string):array to return a list of
attributes sharing the same attribute name.

TODO

• Test on Live

[echarrod]

Looks good, let's wait to test on the example project before merging though 👍

[davidgrayston]

I think there's a breaking change in here (although it's unlikely anyone would be instantiating a profile themselves)

[davidgrayston]

Should this constructor support both [Hash{String => Array<Yoti::Attribute>}] and [Hash{String => Yoti::Attribute}] for backwards compatibility?

Or perhaps [Hash{String => Yoti::Attribute}] and Array<Yoti::Attribute>? (When a hash is provided, process into @attributes_list Array)

[emmas-yoti]

I don't think @attributes can be a Hash of Objects any more? It's always set with a Hash-of-list?

[emmas-yoti]

Oh, wait this isn't a constructor.

[davidgrayston]

Sorry, I meant this comment to correspond with line 18

I was thinking you could provide a Array<Yoti::Attribute> and process this into both a [Hash{String => Array<Yoti::Attribute>}] and [Hash{String => Yoti::Attribute}] (for backwards compatibility).

(but you'd also have to support [Hash{String => Yoti::Attribute}] being passed into the constructor as before, so a bit fiddly)

[davidgrayston]

This indicates a breaking change (although a low risk one)