Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cookie age in app-auth #1793

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

highghlow
Copy link
Contributor

The "expires" parameter was ignored, and the cookie was set to delete on session exit, which is really annoying. This PR fixes this.

NOTE: I honestly have no idea how to test this, so I didn't.

The "expires" parameter was ignored, and the cookie was set to delete on session exit, which is really annoying. This commit fixes this.
res
.cookie("UMBREL_PROXY_TOKEN", proxyToken, {
httpOnly: true,
expires,
maxAge: ONE_WEEK,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one month

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants