-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RTL v0.15.2 update on LND #1156
Conversation
|
Hi @ShahanaFarooqui thanks very much for the RTL updates!
Since the RTL image is built with this Dockerfile it will include the correct nodejs version and we don't need to worry about node on umbrelOS. As of this writing, the Dockerfile is using $ echo -n "RTL v0.15.1 --> node " && sudo docker exec -it ride-the-lightning_web_1 node --version && echo -n "umbrelOS 1.x --> node " && node --version
RTL v0.15.1 --> node v18.20.3
umbrelOS 1.x --> node v18.19.0
Great addition with mempool! Yes, we can pass in the correct I'll create an |
@ShahanaFarooqui I just tested the update before working on When I open the UI I am met with: The upstream error (logged in the RTL container) is:
I have confirmed that in both RTL 0.15.1 and previous 0.14.1 I do not in fact have an Here's my RTL-Config.json:
|
As you already figured, missing I will update the PR after release RTL v0.15.2 with the fix. |
Sounds good @ShahanaFarooqui. I'll push mempool/bitcoin-network url changes after testing them with RTL v0.15.2 |
08ba02c
to
ed7e1f1
Compare
@nmfretz Hey, just pushed a commit with v0.15.2 update. |
Thanks @ShahanaFarooqui!
I have added an exports.sh file with logic that appends a user's current Bitcoin network value to the block explorer url: 5c9cf75
Looking into this properly I've realized that to robustly link to a user's local Mempool instance, RTL would need to include some additional logic. This is because we can't know the exact URL that a user is accessing umbrelOS from. For example, are they connected to their local network and One idea is for us to pass in
Shall we send out this update without local Mempool functionality (once arm64 hiccup is solved), and target next release for local Mempool? |
Here's what we do for the Lightning Node app for your reference: We pass in both the local Mempool port and also the hidden service for Mempool for users who access remotely over Tor (may be overkill for you guys since this is quite umbrelOS specific). Both of these environment variables are available to RTL: umbrel-apps/lightning/docker-compose.yml Lines 37 to 38 in f61b89b
The frontend of the Lightning Node app then constructs the URL:
|
c359fb6
to
05286e2
Compare
05286e2
to
09efd3f
Compare
Thanks for the arm64 fix @ShahanaFarooqui. Tested on arm64 and x86. Going live. |
No description provided.