Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump runtime to 47 #1163

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bump runtime to 47 #1163

wants to merge 2 commits into from

Conversation

TheEvilSkeleton
Copy link
Contributor

Fixes #1155

@TheEvilSkeleton
Copy link
Contributor Author

hmm... all the remaining issues with the CI seem to be out of this MR's scope

@SqAtx
Copy link
Contributor

SqAtx commented Dec 30, 2024

Thanks for looking at it too! I've had 0 free time for software lately :(

hmm... all the remaining issues with the CI seem to be out of this MR's scope

The failures look to be the same as in https://github.com/getting-things-gnome/gtg/actions/runs/12245946645/job/34160890047, which were fixed in 95e33bc. So I think if you just rebase this onto latest master, the tests should work.

If that's the case, and if we've tested that the changes result in a working flatpak, then LGTM.

One day we'll talk about the fact that we're pinning requirements to exact versions, but that doesn't have to be today :)

@SqAtx
Copy link
Contributor

SqAtx commented Jan 26, 2025

I rebased this on top of master and tested the flatpak GHA (https://github.com/SqAtx/gtg/actions/runs/12978178115), but it doesn't run:

$ flatpak run org.gnome.GTG.Devel 
Traceback (most recent call last):
  File "/app/bin/gtg", line 98, in <module>
    from GTG.gtk.application import Application
  File "/app/lib/python3.12/site-packages/GTG/gtk/application.py", line 30, in <module>
    from GTG.core.datastore import Datastore
  File "/app/lib/python3.12/site-packages/GTG/core/datastore.py", line 30, in <module>
    from GTG.core.tasks import TaskStore, Filter
  File "/app/lib/python3.12/site-packages/GTG/core/tasks.py", line 33, in <module>
    from lxml.etree import Element, _Element, SubElement, CDATA
ModuleNotFoundError: No module named 'lxml'

@TheEvilSkeleton
Copy link
Contributor Author

I'll mark the MR as a draft, because I really don't know what's causing this

@TheEvilSkeleton TheEvilSkeleton marked this pull request as draft January 28, 2025 15:47
@gycsaba96
Copy link
Contributor

I'll mark the MR as a draft, because I really don't know what's causing this

It seems a newline (\n) is missing from the end of the python3-requirements.json file.

Fix End of Files.........................................................Failed
- hook id: end-of-file-fixer
- exit code: 1
- files were modified by this hook

Fixing build-aux/python3-requirements.json

@TheEvilSkeleton
Copy link
Contributor Author

Oh yeah, I'm aware of the pre-commit failure. It was more-so the lxml module not being found

@TheEvilSkeleton TheEvilSkeleton marked this pull request as ready for review January 30, 2025 03:18
@TheEvilSkeleton
Copy link
Contributor Author

I managed to fix it and have it working locally. Can anybody test it just for sure?

@gycsaba96
Copy link
Contributor

I managed to fix it and have it working locally. Can anybody test it just for sure?

It works for me too. :)

@TheEvilSkeleton TheEvilSkeleton requested a review from SqAtx January 30, 2025 20:41
Copy link
Contributor

@SqAtx SqAtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to validate the changes using GHA but ran into #1184 :) So we'll fix that one separately.

I built the flatpak locally and it worked, so LGTM!

Note that this fixes #1179 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Target GNOME 47
3 participants