-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump runtime to 47 #1163
base: master
Are you sure you want to change the base?
Bump runtime to 47 #1163
Conversation
484e473
to
fce78a9
Compare
hmm... all the remaining issues with the CI seem to be out of this MR's scope |
Thanks for looking at it too! I've had 0 free time for software lately :(
The failures look to be the same as in https://github.com/getting-things-gnome/gtg/actions/runs/12245946645/job/34160890047, which were fixed in 95e33bc. So I think if you just rebase this onto latest master, the tests should work. If that's the case, and if we've tested that the changes result in a working flatpak, then LGTM. One day we'll talk about the fact that we're pinning requirements to exact versions, but that doesn't have to be today :) |
I rebased this on top of master and tested the flatpak GHA (https://github.com/SqAtx/gtg/actions/runs/12978178115), but it doesn't run:
|
fce78a9
to
9bf9b59
Compare
9bf9b59
to
47f69f3
Compare
I'll mark the MR as a draft, because I really don't know what's causing this |
It seems a newline (
|
Oh yeah, I'm aware of the pre-commit failure. It was more-so the |
47f69f3
to
dc19894
Compare
I managed to fix it and have it working locally. Can anybody test it just for sure? |
It works for me too. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes #1155