Restrict Rouge formatters to Rouge::Formatters namespace #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanhu
force-pushed
the
sh-restrict-rouge-formatter-lookup
branch
from
71c59ea
to
fc7872e
Compare
stanhu
changed the title
stanhu
force-pushed
the
sh-restrict-rouge-formatter-lookup
branch
from
fc7872e
to
28b725c
Compare
ff0218a added support for specifying custom Rouge formatters with the constraint that the formatter be in theRouge::Formatters namespace, but it did not actually enforce this constraint. For example, this is valid: ```ruby Rouge::Formatters.const_get('CSV') => CSV ``` Adding the `false` parameter to `const_get` prevents this: ```ruby Rouge::Formatters.const_get('CSV', false) NameError: uninitialized constant Rouge::Formatters::CSV ```
stanhu
force-pushed
the
sh-restrict-rouge-formatter-lookup
branch
from
28b725c
to
d6a1cbc
Compare
|
Thanks! I think this makes sense also from a security point of view. |
|
@gettalong Thanks! Would you mind merging and tagging a new release? |
|
There will be a release in due time. |
|
Thank you - merged and will be in the upcoming release. |
|
Source of CVSS 9.9 in GitLab. I see no reason to keep it disconnected/under wraps once the patch (and consequently the vector) is known. |
|
this issue got CVE-2021-28834 assigned |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ff0218a added support for specifying custom Rouge formatters with the constraint that the formatter be in the
Rouge::Formattersnamespace, but it did not actually enforce this constraint. For example, this is valid:Adding the
falseparameter toconst_getprevents this: