Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expand file path to full path before processing #466

Merged
merged 1 commit into from
May 16, 2019
Merged

expand file path to full path before processing #466

merged 1 commit into from
May 16, 2019

Conversation

kentso
Copy link
Contributor

@kentso kentso commented May 16, 2019

so that path_regex can match on the full path. It will fix issue #465

@kentso kentso mentioned this pull request May 16, 2019
Closed
@kentso
expand file path to full path before processing
8118803 
so that `path_regex` can match on the full path
@kentso
Copy link
Contributor Author

kentso commented May 16, 2019

Are tests::roundtrip_kms_encryption_context and tests::encrypt_json_file_kms supposed to be ignored or not? When I execute function-test in my local they are ignored.

@autrilla
Copy link
Contributor

Are tests::roundtrip_kms_encryption_context and tests::encrypt_json_file_kms supposed to be ignored or not? When I execute function-test in my local they are ignored.

They require AWS credentials, so we skip them everywhere except for on CI. It looks like CI for this is broken though, but the test failure is irrelevant to your patch.

autrilla
autrilla approved these changes May 16, 2019
View reviewed changes
Copy link
Contributor

@autrilla autrilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks for the additions to the docs too.

@autrilla autrilla merged commit ea2a10b into getsops:master May 16, 2019
@kentso kentso deleted the regex-path branch May 16, 2019 07:08
@michael-k michael-k mentioned this pull request Jun 12, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@autrilla autrilla autrilla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kentso @autrilla