Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): Build last 2 Go versions #1531

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

reneleonhardt
Copy link

Features

  • CI builds both latest Go versions (1.21 and 1.22)

Signed-off-by: Rene Leonhardt <65483435+reneleonhardt@users.noreply.github.com>
Copy link
Contributor

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@@ -93,10 +94,10 @@ jobs:

- uses: actions/download-artifact@65a9edc5881444af0b9093a5e628f2fe47ea3b2e # v4.1.7
with:
name: sops-linux-amd64-${{ github.sha }}
name: sops-1.22-linux-amd64-${{ github.sha }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's likely better to use a one-element matrix to move these versions out from the steps.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no matrix in this job (test) 🤔
You see that the build job is just required for the test job, after a successful build both versions are available.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, but you could add a matrix for test as well, to move the versions out from the steps into the matrix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants