-
Notifications
You must be signed in to change notification settings - Fork 855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): Update Go dependencies #1527
base: main
Are you sure you want to change the base?
Conversation
227b53b
to
8de8db6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! I think your PR is doing way too many things in one PR that should happen in multiple smaller PRs. Can you please split it up into smaller parts, such as:
- Updating Go deps.
- Extending CI to build multiple deps.
- Updating the release process and using dependabot for updating Dockerfile.
- Updating Rust dependencies and using dependabot for updating Cargo.toml.
- Updating Makefile.
Thanks!
14c78b6
to
de2a7c0
Compare
.github/workflows/release.yml
Outdated
@@ -65,7 +65,7 @@ jobs: | |||
id: goreleaser | |||
uses: goreleaser/goreleaser-action@286f3b13b1b49da4ac219696163fb8c1c93e1200 # v6.0.0 | |||
with: | |||
version: 1.21.x | |||
version: 1.22.x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the Go version BTW, but the goreleaser version.
Ref: #1547 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, this is confusing, why would you use a goreleaser version from Sept 2023 if 1.26.x is the last 1.x? 🤔
I suggest "updating" to 1.26 first, but 2.1 is around the corner...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the last person who updated the version also thought it is a Go version (which it is not). I would avoid updating this at all until we have proper packaging testing (see #1547 for what the update from 1.20.x to 1.21.x caused).
Signed-off-by: Rene Leonhardt <65483435+reneleonhardt@users.noreply.github.com>
Features