-
Notifications
You must be signed in to change notification settings - Fork 855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(publish) Publish Secrets to Azure Key Vault #1240
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! I cannot say much about the functionality itself (in fact I've never used sops publish
:) ), but I have some comments on the RST documentation.
Thanks for the review, and sorry for the late follow-up. I've added the requested changes to the README.rst file, and merged current main. |
This appears to be only used for pushing Docker images to a registry we no longer have access to. As we need to rework the release process as a whole (using GitHub Actions), remove it for now. As the only thing it yields at present are failure notifications in my inbox. Signed-off-by: Hidde Beydals <hidde@hhh.computer> Signed-off-by: Daniel Münch <daniel@revenew.co>
Signed-off-by: Daniel Münch <daniel@revenew.co>
Signed-off-by: Daniel Münch <daniel@revenew.co>
Signed-off-by: Daniel Münch <daniel@revenew.co>
Signed-off-by: Daniel Münch <daniel@revenew.co>
Signed-off-by: Daniel Münch <daniel@revenew.co> # Conflicts: # go.mod # go.sum
Hi,
first, thanks a lot for sops - a great tool which accommodates many of our needs in regards to secret management!
For our specific use-case, we needed to publish secrets to Azure Key Vault Secrets - While the general publish functionality of sops is useful, it currently lacks support to publish secrets to Azure Key Vault Secrets. This PR is an attempt to get this added.
Besides this, this PR also adds support for the
input-type
command line flag to publish command .I'm a first-time contributor, and not too experienced Golang, so I hope I did things the right way. Happy to make any changes if required.
Regarding testing, there weren't any existing tests for the other publishers, so I couldn't just easily follow existing examples.