-
Notifications
You must be signed in to change notification settings - Fork 855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ocikms: Oracle Cloud KMS support #1226
base: main
Are you sure you want to change the base?
Conversation
@@ -36,7 +36,7 @@ generate: keyservice/keyservice.pb.go | |||
$(GO) generate | |||
|
|||
%.pb.go: %.proto | |||
protoc --go_out=plugins=grpc:. $< | |||
protoc --go_out=. --go-grpc_out=require_unimplemented_servers=false:. $< |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be the current way of generating files with protoc since 1.20 I believe.
The generated files are also split now as you can see below.
The flag require_unimplemented_servers=false
is necessary to preserve the previous functionality.
I have also tried
protoc-gen-go v1.23.0
protoc v3.13.0
but I am still getting errors with the plugin settings.
I don't think this is an issue but just flagging for the reviewer
@@ -1,5 +1,7 @@ | |||
syntax = "proto3"; | |||
|
|||
option go_package = "/keyservice"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added this ad best practice and because I was getting errors because of this as well when doing make generate
Hi there, I found myself needing this so I thought it was a good opportunity to contribute a little.
Happy to make the necessary changes, I tried to comply with style as much as possible.
Fixes #981
cc: @colemickens, @davidpinhas, @b-dean
Basic Demo
sops_oci_kms_demo.mp4