Stop putting system.base at the front of the order #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ermo
force-pushed
the
undo-system.base-reorder-operation
branch
2 times, most recently
from
defef0e to
c1d7bd0
Compare
We now use OrderedSets, which keep the original topological sort, so this shouldn't actually be necessary now. This also implies that the only function of system.base is for the packages in it to be un-removable. Signed-off-by: Rune Morling <ermo@serpentos.com>
This should make the testing of PRs before landing them more viable. Signed-off-by: Rune Morling <ermo@serpentos.com>
In addition, list enabled repositories in ${SOSROOT}
Signed-off-by: Rune Morling <ermo@serpentos.com>
ermo
force-pushed
the
undo-system.base-reorder-operation
branch
from
c1d7bd0 to
515f101
Compare
|
In the testing I have done locally and for building VMs/chroots/ISO, the above changes have yet to break anything FWIW. |
ReillyBrogan
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now use OrderedSets, which keep the original topological sort, so this shouldn't actually be necessary now.
This also implies that the only function of system.base is for the packages in it to be un-removable.
NB: This change is experimental and will need loads of upgrade testing!