Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: update actions/upload-artifact to v4 with merge #1521

Merged
merged 2 commits into from
Sep 18, 2024
Merged

ci: update actions/upload-artifact to v4 with merge #1521

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8635bd1
upload-artifact v4 with merge
joshuarli Sep 17, 2024
89eab21
better name
joshuarli Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 26 additions & 6 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,12 @@ jobs:
mv target/release/symsorter build/symsorter-Linux-x86_64
mv target/release/symbolicli build/symbolicli-Linux-x86_64

- uses: actions/upload-artifact@v3.1.1
with:
name: ${{ github.sha }}
name: artifact-linux-${{ github.sha }}
path: build/*
if-no-files-found: 'error'
# since this artifact will be merged, compression is not necessary
compression-level: '0'

mac:
# Note: This doesn't use a build matrix, as it requires a last step to merge the x86
Expand Down Expand Up @@ -99,10 +101,13 @@ jobs:
cd target/x86_64-apple-darwin/release
zip -r ../../../build/symbolicator-aarch64-apple-darwin-debug.zip symbolicator.dSYM

- uses: actions/upload-artifact@v3.1.1
- uses: actions/upload-artifact@v4
with:
name: ${{ github.sha }}
name: artifact-mac-${{ github.sha }}
path: build/*
if-no-files-found: 'error'
# since this artifact will be merged, compression is not necessary
compression-level: '0'

windows:
name: Build Tools on Windows
Expand All @@ -127,7 +132,22 @@ jobs:
mv symbolicli.exe symbolicli-Windows-x86_64.exe
mv wasm-split.exe wasm-split-Windows-x86_64.exe

- uses: actions/upload-artifact@v3.1.1
- uses: actions/upload-artifact@v4
with:
name: ${{ github.sha }}
name: artifact-windows-${{ github.sha }}
path: target/release/*-Windows-x86_64.exe
if-no-files-found: 'error'
# since this artifact will be merged, compression is not necessary
compression-level: '0'

merge:
name: Create Release Artifact
runs-on: ubuntu-latest
needs: [linux, mac, windows]
steps:
- uses: actions/upload-artifact/merge@v4
with:
# Craft expects release assets from github to be a single artifact named after the sha.
name: ${{ github.sha }}
pattern: artifact-*
delete-merged: true
Loading