feat(grouping): add more in-app exclusion rules for Rust #87990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
lcian
changed the title
rust_begin_unwind not in app
armenzg
approved these changes
Mar 26, 2025
Swatinem
approved these changes
Mar 27, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Mar 27, 2025
<!-- Describe your PR here. --> - `rust_begin_unwind` is often the top "in app" frame for Rust panics, which makes it end up in the top level issue description even though it's not informative at all - `panic_fmt` is another possible entrypoint for panics that we were not considering. At the moment it's redundant to add it, as the only possible frame that is not in app above it is the aforementioned `rust_begin_unwind`, but could be useful if new versions of Rust introduce other "intermediate" frames with a different name - I did not use `^-group -group` to not break grouping for existing events
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rust_begin_unwindis often the top "in app" frame for Rust panics, which makes it end up in the top level issue description even though it's not informative at allpanic_fmtis another possible entrypoint for panics that we were not considering. At the moment it's redundant to add it, as the only possible frame that is not in app above it is the aforementionedrust_begin_unwind, but could be useful if new versions of Rust introduce other "intermediate" frames with a different name^-group -groupto not break grouping for existing events