Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(replay): remove refs to GA'd HE flag #77881

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(replay): remove refs to GA'd HE flag #77881

wants to merge 1 commit into from

Conversation

aliu39
Copy link
Member

@aliu39 aliu39 commented Sep 20, 2024

No description provided.

@aliu39 aliu39 requested a review from a team as a code owner September 20, 2024 22:54
@github-actions github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Sep 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@michellewzhang
Copy link
Member

michellewzhang commented Sep 20, 2024 •
edited
Loading

should probably split up backend and frontend changes into separate PRs

@aliu39
Copy link
Member Author

aliu39 commented Sep 20, 2024

oops, true!

@aliu39
Copy link
Member Author

aliu39 commented Sep 20, 2024

Actually, I don't think these changes are interdependent in any way. Do you think it's ok to merge them in one?

@michellewzhang
Copy link
Member

Actually, I don't think these changes are interdependent in any way. Do you think it's ok to merge them in one?

frontend + backend deploy at diff times, so you don't want to risk it - we should generally always rm FE ff references first, then the BE ones

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aliu39 @michellewzhang