Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(issue-views): Update banner and tooltip copy, make banner dismissable, feedback -> read docs #77878

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MichaelSun48
Copy link
Member

Makes a couple changes to the add view page for EA readiness:

  1. Updates the banner copy to call out: views are user scoped, views are reorderable, and that custom searches are persisted temporarily (only appears if you actually have any custom searches)
  2. Adds a dismiss button to the banner
  3. Switches the "Give Feedback" button for a "Read Docs" button
  4. Adds a "Learn More" that redirects to docs within the saved searches tooltip

IMPORTANT: docs are not done yet, so the docs links are broken. I will not merge this until the docs links resolve.

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Sep 20, 2024
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 30.76923% with 9 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
static/app/views/issueList/addViewPage.tsx 30.76% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #77878      +/-   ##
==========================================
- Coverage   78.12%   78.11%   -0.01%     
==========================================
  Files        6991     6994       +3     
  Lines      310002   310076      +74     
  Branches    50724    50740      +16     
==========================================
+ Hits       242182   242226      +44     
- Misses      56101    56124      +23     
- Partials    11719    11726       +7     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant