Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(substatus): Add migration to fix substatuses #77741

Merged
merged 4 commits into from
Sep 20, 2024
Merged

Conversation

snigdhas
Copy link
Member

Fixes substatus inconsistencies by removing substatus for groups that aren't unresolved or ignored and recalculating substatus for unresolved/ignored groups that have an incompatible substatus.

From this query, there should be around 3k groups to fix.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 18, 2024
Copy link
Contributor

This PR has a migration; here is the generated SQL for src/sentry/migrations/0764_migrate_bad_status_substatus_rows.py ()

--
-- Raw Python operation
--
-- THIS OPERATION CANNOT BE WRITTEN AS SQL

@snigdhas snigdhas marked this pull request as ready for review September 18, 2024 23:45
@snigdhas snigdhas requested a review from a team as a code owner September 18, 2024 23:45
@snigdhas snigdhas requested a review from a team September 18, 2024 23:45
Copy link
Member

@markstory markstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migration/ORM usage looks good to me, but I'm not well versed in the requirements around issue substatus.

@snigdhas snigdhas enabled auto-merge (squash) September 20, 2024 22:25
@snigdhas snigdhas merged commit ad84c9e into master Sep 20, 2024
49 checks passed
@snigdhas snigdhas deleted the snigdha/fix-bad-rows branch September 20, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants