Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(uptime): Add validator fields for method, body, header #77723

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

davidenwang
Copy link
Contributor

Adds new fields to the validator matching up with #77611

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 18, 2024
@davidenwang davidenwang marked this pull request as ready for review September 18, 2024 19:44
@davidenwang davidenwang requested a review from a team as a code owner September 18, 2024 19:44
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 90.19608% with 5 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/uptime/endpoints/validators.py 89.28% 3 Missing ⚠️
src/sentry/uptime/subscriptions/subscriptions.py 90.47% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #77723   +/-   ##
=======================================
  Coverage   78.12%   78.12%           
=======================================
  Files        6996     6996           
  Lines      310241   310290   +49     
  Branches    50763    50769    +6     
=======================================
+ Hits       242363   242414   +51     
- Misses      56145    56146    +1     
+ Partials    11733    11730    -3     

@davidenwang davidenwang marked this pull request as draft September 19, 2024 12:00
@wedamija wedamija force-pushed the davidenwang/validator-custom-method-headers-body branch from b5b8c6d to 6aa2a89 Compare September 21, 2024 01:07
@wedamija wedamija marked this pull request as ready for review September 21, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants