Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dashboards): Reduce instrumentation for AutoSizedText #77597

Merged

Conversation

gggritso
Copy link
Member

Rollout's basically done, this is the last thing. I don't want to create transactions for every resize, that's too much noise.

  1. Remove some unnecessary tags (e.g., iteration exceeded) since that condition has mostly disappeared. The iteration count makes the same point
  2. Do not create a transaction. In fact, do the opposite: attach a span to an existing transaction if it exists, otherwise just drop it, it's okay
  3. Remove custom duration measurements. This has done its job, and it wasn't nearly as relevant for span durations as transaction durations anyway

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Sep 17, 2024
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../app/views/dashboards/widgetCard/autoSizedText.tsx 0.00% 16 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #77597       +/-   ##
===========================================
- Coverage   88.40%   78.05%   -10.35%     
===========================================
  Files        2998     6981     +3983     
  Lines      186501   308732   +122231     
  Branches    30640    50594    +19954     
===========================================
+ Hits       164878   240986    +76108     
- Misses      15598    56056    +40458     
- Partials     6025    11690     +5665     

@gggritso gggritso marked this pull request as ready for review September 17, 2024 03:32
@gggritso gggritso requested a review from a team as a code owner September 17, 2024 03:32
Copy link
Member

@narsaynorath narsaynorath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gggritso gggritso merged commit 083f5c7 into master Sep 20, 2024
43 of 44 checks passed
@gggritso gggritso deleted the chore/dashboards/reduce-auto-sized-number-instrumentation branch September 20, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants