Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: work around pip not having retries for streamed downloads #60195

Merged
merged 1 commit into from
Nov 20, 2023
Merged

ref: work around pip not having retries for streamed downloads #60195

merged 1 commit into from
Nov 20, 2023

Conversation

asottile-sentry
Copy link
Member

pypa/pip#12383 (comment)

this is a terrible hack -- essentially:

  • write a small .pth file to monkeypatch pip for any calls into the virtualenv site-packages
  • add a retrier to Downloader.__call__
  • instrument all of our virtualenv creation with it

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 17, 2023
@asottile-sentry asottile-sentry force-pushed the asottile-hack-pip branch 2 times, most recently from 02fd11a to bbac7b3 Compare November 17, 2023 21:41
@asottile-sentry asottile-sentry marked this pull request as ready for review November 20, 2023 15:40
@asottile-sentry asottile-sentry requested a review from a team as a code owner November 20, 2023 15:40
@asottile-sentry asottile-sentry requested a review from a team November 20, 2023 15:40
joshuarli
joshuarli approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@joshuarli joshuarli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL

@asottile-sentry asottile-sentry merged commit f4f9fa7 into master Nov 20, 2023
@asottile-sentry asottile-sentry deleted the asottile-hack-pip branch November 20, 2023 20:19
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joshuarli joshuarli joshuarli approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asottile-sentry @joshuarli