Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add OpenAPI docs for monitor endpoints #42850

Merged
merged 1 commit into from
Jan 6, 2023
Merged

feat: Add OpenAPI docs for monitor endpoints #42850

merged 1 commit into from
Jan 6, 2023

Conversation

dcramer
Copy link
Member

@dcramer dcramer commented Jan 5, 2023 •
edited
Loading

Refs #42283

@dcramer dcramer requested a review from a team as a code owner January 5, 2023 21:33
@dcramer
Copy link
Member Author

dcramer commented Jan 5, 2023

Need to make sure these do what are expected, and ideally label them as "Beta" somehow.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 5, 2023
JoshFerge
JoshFerge reviewed Jan 5, 2023
View reviewed changes
Copy link
Member

@JoshFerge JoshFerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think the endpoints have to be removed from src/sentry/apidocs/public_exclusion_list.py for the schema to be generated (grandfathered endpoints before api docs schema changes).

@vercel
Copy link

vercel bot commented Jan 5, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
storybook 🔄 Building (Inspect) Jan 6, 2023 at 4:44PM (UTC)

@dcramer dcramer force-pushed the feat/document-monitors-api branch 2 times, most recently from 48f6c4b to 0250f8b Compare January 5, 2023 22:14
@dcramer
Copy link
Member Author

dcramer commented Jan 5, 2023

Only thing that is blocking ATM is to determine how to undocument one of the two endpoints (e.g. the one without the organization prefix URL).

@dcramer
Copy link
Member Author

dcramer commented Jan 5, 2023

Done and done. Lets wait to merge til #42825 is in.

@dcramer
Copy link
Member Author

dcramer commented Jan 5, 2023

I THINK the failed check is what we'd expect, but someone from ecosystem could confirm? Its just showing the newly added schema/sidebar thing. I didn't build these against the prod API, but I can try to do that locally (tests wouldnt work for me due to some DB errors)

@dcramer
Copy link
Member Author

dcramer commented Jan 6, 2023

Alright gonna ship it and see what breaks.

@dcramer dcramer enabled auto-merge (squash) January 6, 2023 17:24
@dcramer dcramer merged commit 37c3ee8 into master Jan 6, 2023
@dcramer dcramer deleted the feat/document-monitors-api branch January 6, 2023 17:40
@dcramer dcramer mentioned this pull request Jan 6, 2023
Merged
dcramer added a commit that referenced this pull request Jan 6, 2023
@dcramer
fix: Correct API usage for Crons (#42886)
8634c54 
- Remove legacy docstrings and replace with better descriptions
- Missing checkin details endpoint for Hybrid Cloud

Refs #42850
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshFerge JoshFerge JoshFerge left review comments

@markstory markstory markstory left review comments

@davidenwang davidenwang davidenwang approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dcramer @markstory @JoshFerge @davidenwang