fix(options): Remove SENTRY_URL_PREFIX
#34342
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgaeta
force-pushed
the
fix/sentry-url-prefix
branch
from
acc5ad7 to
53c8021
Compare
ceorourke
reviewed
May 6, 2022
|
@mgaeta I know that this has been deprecated for a while, but there's still a risk associated with removing this field. Based on the Github issue, maybe the better fix is to only spit out the deprecation warning if |
mgaeta
force-pushed
the
fix/sentry-url-prefix
branch
from
53c8021 to
48e8225
Compare
|
Not thrilled about this approach, would prefer we get to the bottom of why the initializer is running more than once. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user starts up a brand new server they're seeing this warning:
The setting was deprecated seven years ago in #2402 so I hope it's safe to delete.
Fixes getsentry/self-hosted#1309.