Bump: Sentry .NET 3.33.1 #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
lucas-zimerman
commented
Jun 16, 2023
•
lucas-zimerman
commented
- Bump SDK To version 3.33.1
- Remove old dependency to Windows Virtual Machine from 2019.
- Bump sample target versions to build on the latest version of Visual Studio
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: microsoft/setup-msbuild@v1.1 | ||
| if: startsWith(matrix.os, 'windows') | ||
| - name: Install Windows SDK Version 10.0.16299.0 | ||
| uses: GuillaumeFalourd/setup-windows10-sdk-action@v1.11 |
There was a problem hiding this comment.
Can we stay on windows-2019 and avoid running this instead?
If not, once you review what this action does, can we ping the commit sha here instead of @v1.11 ?
There was a problem hiding this comment.
windows-2019 doesn't support the latest Android targets.
I checked the action and it's just a single powershell script that does the following:
download https://download.microsoft.com/download/F/8/E/F8EC2F14-375D-4C2E-9C2D-51CA8F7F590B/16299.15.170928-1534.rs3_release_WindowsSDK.iso
mount iso
run WinSDKSetup.exe
Start-Process with the following args "/features OptionId.UWPCpp /q"
where $WindowsSDKOptions is @("OptionId.UWPCpp")
Since it's a single file, it may make more sense to just leave the script inside of the project? This way other contributors could also make use of it if needed.
There was a problem hiding this comment.
Yeah feel free to copy the steps in
bruno-garcia
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.