fix: hide StackTraceMode from options to avoid accidental errors when…

… used with IL2CPP
getsentry · Oct 21, 2022 · 63c011c · 63c011c
1 parent e852e03
commit 63c011c
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/Directory.Build.targets b/Directory.Build.targets
@@ -396,7 +396,7 @@ Log.LogMessage("Unity Version: " + version);
     </Task>
   </UsingTask>
 
-    <!-- Locate the TestRunner.dlls by filling the wildcard with the template version number. 3d is the default template -->
+  <!-- Locate the TestRunner.dlls by filling the wildcard with the template version number. 3d is the default template -->
   <UsingTask TaskName="LocateTestRunner" TaskFactory="RoslynCodeTaskFactory" AssemblyFile="$(MSBuildToolsPath)\Microsoft.Build.Tasks.Core.dll">
     <ParameterGroup>
       <UnityLibcache ParameterType="System.String" Required="true" />

diff --git a/src/Sentry.Unity/SentryUnityOptions.cs b/src/Sentry.Unity/SentryUnityOptions.cs
@@ -116,6 +116,9 @@ public sealed class SentryUnityOptions : SentryOptions
         /// </remarks>
         public bool Il2CppLineNumberSupportEnabled { get; set; } = true;
 
+        /// This option is hidden due to incompatibility between IL2CPP and Enhanced mode.
+        private new StackTraceMode StackTraceMode { get; set; }
+
         // Initialized by native SDK binding code to set the User.ID in .NET (UnityEventProcessor).
         internal string? _defaultUserId;
         internal string? DefaultUserId
@@ -175,8 +178,9 @@ internal SentryUnityOptions(SentryMonoBehaviour behaviour, IApplication applicat
             RequestBodyCompressionLevel = CompressionLevelWithAuto.NoCompression;
             InitCacheFlushTimeout = System.TimeSpan.Zero;
 
-            // Ben.Demystifer not compatible with IL2CPP
-            StackTraceMode = StackTraceMode.Original;
+            // Ben.Demystifer not compatible with IL2CPP. We could allow Enhanced in the future for Mono.
+            // See https://github.com/getsentry/sentry-unity/issues/675
+            base.StackTraceMode = StackTraceMode.Original;
             IsEnvironmentUser = false;
 
             if (application.ProductName is string productName

diff --git a/test/Sentry.Unity.Tests/SentryUnityTests.cs b/test/Sentry.Unity.Tests/SentryUnityTests.cs
@@ -23,7 +23,6 @@ public void AsyncStackTrace()
         {
             var options = new SentryUnityOptions();
             options.AttachStacktrace = true;
-            options.StackTraceMode = StackTraceMode.Original;
             var sut = new SentryStackTraceFactory(options);
 
             IList<SentryStackFrame> framesSentry = null!;