Merge pull request #36 from LouisTrezzini/feature/raven-options

Give access to all of the RavenClient options
getsentry · Dec 30, 2016 · 4250536 · 4250536
2 parents 235aab6 + 20df593
commit 4250536
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 4 deletions.
diff --git a/src/Sentry/SentryBundle/DependencyInjection/Configuration.php b/src/Sentry/SentryBundle/DependencyInjection/Configuration.php
@@ -34,6 +34,11 @@ public function getConfigTreeBuilder()
                 ->scalarNode('dsn')
                     ->defaultNull()
                 ->end()
+                ->arrayNode('options')
+                    ->treatNullLike(array())
+                    ->prototype('scalar')->end()
+                    ->defaultValue(array())
+                ->end()
                 ->scalarNode('error_types')
                     ->defaultNull()
                 ->end()

diff --git a/src/Sentry/SentryBundle/Resources/config/services.yml b/src/Sentry/SentryBundle/Resources/config/services.yml
@@ -1,7 +1,7 @@
 services:
     sentry.client:
         class: '%sentry.client%'
-        arguments: ['%sentry.dsn%', {'error_types': '%sentry.error_types%'}]
+        arguments: ['%sentry.dsn%', %sentry.options%, '%sentry.error_types%']
         calls:
             - [setRelease, ['%sentry.release%']]
             - [setEnvironment, ['%sentry.environment%']]

diff --git a/src/Sentry/SentryBundle/SentrySymfonyClient.php b/src/Sentry/SentryBundle/SentrySymfonyClient.php
@@ -4,10 +4,10 @@
 
 class SentrySymfonyClient extends \Raven_Client
 {
-    public function __construct($dsn=null, $options=array())
+    public function __construct($dsn=null, $options=array(), $error_types='')
     {
-        if (array_key_exists('error_types', $options)) {
-            $exParser = new ErrorTypesParser($options['error_types']);
+        if (is_string($error_types) && !empty($error_types)) {
+            $exParser = new ErrorTypesParser($error_types);
             $options['error_types'] = $exParser->parse();
         }
 

diff --git a/test/Sentry/SentryBundle/Test/DependencyInjection/ExtensionTest.php b/test/Sentry/SentryBundle/Test/DependencyInjection/ExtensionTest.php
@@ -115,6 +115,24 @@ public function test_that_it_uses_dsn_value()
         );
     }
 
+    public function test_that_it_uses_options_value()
+    {
+        $container = $this->getContainer(array(
+            static::CONFIG_ROOT => array(
+                'options' => array(
+                    'http_proxy' => 'http://user:password@host:port'
+                ),
+            ),
+        ));
+
+        $options = $container->getParameter('sentry.options');
+
+        $this->assertSame(
+            'http://user:password@host:port',
+            $options['http_proxy']
+        );
+    }
+
     public function test_that_it_uses_defined_class_as_exception_listener_class_by_default()
     {
         $container = $this->getContainer();