Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove versions from local dev-dependencies #378

Merged
merged 1 commit into from
Nov 2, 2021
Merged

Conversation

Swatinem
Copy link
Member

This way, cargo will not verify the versions when publishing, removing
the need to use cargo-hack for publishing.

fixes #374

This way, cargo will not verify the versions when publishing, removing
the need to use `cargo-hack` for publishing.
@Swatinem Swatinem requested a review from a team October 27, 2021 09:20
Copy link
Contributor

@relaxolotl relaxolotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes look good, but it looks like CI isn't happy with this right now 😞

i don't see anything in the diff that deliberately tries to fix the problem with circular imports that you mentioned in the linked issue - will that be a problem once this is merged in?

@Swatinem
Copy link
Member Author

Swatinem commented Nov 2, 2021

The code coverage CI job is broken right now, its optional anyway.

The actual fix here is that cargo > 1.40 will ignore path-only dev-dependencies when publishing, thus we don’t need cargo-hack anymore. (Before, cargo would reject the release, because it checks that dev-dependencies actually exist on crates.io before publishing, which they don’t in case of circular deps)

@Swatinem Swatinem merged commit d54c912 into master Nov 2, 2021
@Swatinem Swatinem deleted the fix/devdpes branch November 2, 2021 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.cargo_vcs_info.json not included in packaged crates
2 participants