Skip to content

Conversation

jan-auer
Copy link
Member

Good bug.

The curl transport implementation works like this:

  • Serialize the event into an in-memory buffer
  • Determine the length of the buffer and let curl read it
  • In the read function, pass a chunk into the buffer

However, the read function always sliced the beginning of the buffer, rather than reading it chunk by chunk. This is fixed by wrapping the buffer into a cursor, which implements read correctly.

@jan-auer jan-auer requested review from mitsuhiko and tonyo July 29, 2019 15:17
@jan-auer jan-auer self-assigned this Jul 29, 2019
@jan-auer jan-auer merged commit 83f227f into master Jul 29, 2019
@jan-auer jan-auer deleted the fix/curl-read-loop branch July 29, 2019 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants