feat: add support for openssl-less builds #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This issue is related to getsentry#88 and would prevent issues like it when openssl 1.2 comes out. Currently, sentry-rust depends on reqwest with default feature flags, which pulls in `native-tls` and `openssl`. This causes multiple issues: 1. On systems without openssl header packages installed, openssl-sys won't build. 2. If distributions like arch linux update to newer versions of openssl, issues like getsentry#88 will arise 3. Systems that don't support openssl are not supported (although targeting embedded systems with non-unix OSes is probably not a goal in this project) This commit adds support for building reqwest with rustls support, using the new feature flag `rustls`. This fixes getsentry#136.
|
I would merge it but since all the other features are prefixed with |
|
I named them |
|
Was just looking at adding this support as well so happy to find this PR :) We also have a need for using |
|
Wanted to pull it already but i'm investigating at the moment why appveyor is barfing on ring :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue is related to #88 and would prevent issues like it when
openssl 1.2 comes out.
Currently, sentry-rust depends on reqwest with default feature flags,
which pulls in
native-tlsandopenssl.This causes multiple issues:
won't build.
issues like Issue with openssl 1.1.1, update sentry to use reqwest 0.9? #88 will arise
targeting embedded systems with non-unix OSes is probably not a goal
in this project)
This commit adds support for building reqwest with rustls support, using
the new feature flag
rustlswith_rustls.This fixes #136.