Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve before_send and before_send_transaction's return value handling #2504

Merged
merged 4 commits into from
Jan 6, 2025

Update sentry-ruby/lib/sentry/client.rb

2f8bd4e
Select commit
Loading
Failed to load commit list.
Merged

Improve before_send and before_send_transaction's return value handling #2504

Update sentry-ruby/lib/sentry/client.rb
2f8bd4e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jan 5, 2025 in 0s

98.18% (-0.02%) compared to ad535cc

View this Pull Request on Codecov

98.18% (-0.02%) compared to ad535cc

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.18%. Comparing base (ad535cc) to head (2f8bd4e).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2504      +/-   ##
==========================================
- Coverage   98.20%   98.18%   -0.02%     
==========================================
  Files         128      128              
  Lines        4837     4847      +10     
==========================================
+ Hits         4750     4759       +9     
- Misses         87       88       +1     
Components Coverage Δ
sentry-ruby 98.57% <100.00%> (+<0.01%) ⬆️
sentry-rails 97.07% <ø> (ø)
sentry-sidekiq 97.09% <ø> (-0.33%) ⬇️
sentry-resque 92.85% <ø> (ø)
sentry-delayed_job 95.65% <ø> (ø)
sentry-opentelemetry 99.31% <ø> (ø)
Files with missing lines Coverage Δ
sentry-ruby/lib/sentry/client.rb 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes