Drop IRB's patch #2104
Merged
Drop IRB's patch #2104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 74103ea.
|
@sl0thentr0py Thanks for the workaround btw. I didn't notice the issue until I saw your patch & another issue report about it. |
Codecov ReportPatch has no changes to coverable lines. 📢 Thoughts on this report? Let us know!. |
sl0thentr0py
approved these changes
Sep 8, 2023
st0012
commented
Sep 9, 2023
| @@ -24,6 +24,7 @@ if rails_version > Gem::Version.new("7.0.0") | |||
| gem "rails", github: "rails/rails" | |||
| else | |||
| gem "rails", "~> #{rails_version}" | |||
| gem "psych", "~> 3.0.0" | |||
There was a problem hiding this comment.
Because Rails 6 doesn't require psych's version, it could still be bumped to a incompatible version. So we need to lock it here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've fixed the issue in ruby/irb#704 and released it in v1.8.1, so this patch is no longer needed 😄
#skip-changelog