-
-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support transaction (part 1) #1108
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1108 +/- ##
==========================================
+ Coverage 97.92% 98.04% +0.11%
==========================================
Files 133 144 +11
Lines 5601 6087 +486
==========================================
+ Hits 5485 5968 +483
- Misses 116 119 +3
Continue to review full report at Codecov.
|
a197d25
to
24506b7
Compare
24506b7
to
1d50851
Compare
48c9496
to
8fba220
Compare
sampled_flag = "" | ||
sampled_flag = @sampled ? 1 : 0 unless @sampled.nil? | ||
|
||
"#{@trace_id}-#{@span_id}-#{sampled_flag}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think here is a nit, if sampled
is nil which is a valid value we would emit #{@trace_id}-#{@span_id}-
with a trailing -
we should change that (eventho I think it would still work)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if @samped
is nil
, sampled_flag
will be an empty string, which will add nothing to the string and become
"#{@trace_id}-#{@span_id}-"
so exactly the expected behavior 😄
here's the spec for such case https://github.com/getsentry/sentry-ruby/pull/1108/files#diff-a54e868d59f29d1f5369002784782b73b90c18c6493aab761e0230a51329fb6bR52-R61
This PR builds the groundwork for the performance monitoring feature. It can already send the new "transaction" type data to the server now.
This feature can be enabled by setting:
Every event happened inside a transaction will now have a new
Trace Details
section:By clicking
Search By Trace
, users can see all the events associated with that transaction, including the transaction event itself.And this is how a transaction event looks like:
Upcoming Features